The Preferences dialog panels are too much different from one another. Checkboxes are sometimes before sometimes after their text ; all before and set as text (ie. can be clicked to change the check box state) would be better.
Some strings are not in the language bundle.
LocationPanel had a wrong value (cf. comment and patch), but it seems you didn’t commit the file so maybe you don’t want those changes. Sorry for bothering you.
Hey Vincent, there weren't any changes to the LocationPanel that I could see in the first set of patches you provided.
In the LocationPanel patch I am getting two errors:
Description Resource Path Location Type
FD_USER cannot be resolved or is not a field LocationPanel.java /pcgendev/code/src/java/pcgen/gui2/prefs line 401 Java Problem
The method getUserSettingsDirFromFilePath() is undefined for the type ConfigurationSettings LocationPanel.java /pcgendev/code/src/java/pcgen/gui2/prefs line 439 Java Problem
I found why, it is because I changed a file for two different issues. The changes were either lost or incorporated into the other issue, CODE-1204.
If I used quilt correctly to separate the patches, the file should contain the changes without mixing it with another issue’s patch.
Patch for applied, so LocationPanel should be right now.