PREFEAT:Weapon Specialization (TYPE=Piercing.Melee) not working

Description

Need to be able to match only on a weapon specialization that matches all given types.

Environment

JRE 1.6

Activity

Show:
Brad Kester
October 12, 2012, 2:56 PM

Alright, I'll do this tomorrow, Friday the 12th, around 10:00am CST. Just so you know when I'll be in the files

James Dempsey
October 12, 2012, 3:03 PM

I'm a little surprised that the type is checking only the equipment type and not the proficiency type. That probably dates back to when weapon proficiencies were not full objects. Can you see any negative side-effects of adding checking of the proficiency to the TYPE processing?

Brad Kester
October 12, 2012, 3:11 PM

While I know this comment was directed at Andrew, my first thought was "Well, only if proficiencies will have TYPE's that shouldn't be in EquipmentType." I could run a script to compare all the TYPEs from the equipment and their respective proficiency TYPE's, but it'd have to be tomorrow. :/

Andrew Maitland
October 12, 2012, 3:22 PM

I don't see any negative. Most of them are duplicated. It's always been a little confusing which bonus looks where or prexxx checks against something else. I'd have no problem with it looking at both.

James Dempsey
October 12, 2012, 3:37 PM

Completed in

Cancelled

Assignee

James Dempsey

Reporter

Brad Kester

Theme

None

Epic/Theme

None

Pending User Input

None

Affects versions

Priority

Minor
Configure