File->Save As fails for master with companion not loaded

Description

Opening an existing character, and using 'File->Save as...' to save as a new name, doesn't actually create the new save file.
It's not until you then close the character that it prompts to save, and actually creates the save file.

Things work as expected if you use this menu option for a brand new character.

Environment

None

Activity

Show:
James Dempsey
October 19, 2012, 3:34 PM

I'm having trouble reproducing this one (with an existing character). Are there any specific steps you take which can cause it to save or not save?

Dave Griffin
October 20, 2012, 4:25 AM

Looks like it may be caused by my homebrew, and a specific character... I too have had troubles recreating this with a standard source / new character... This is a character that (bug logged separately) gave me an issue with the summary indicating skill points remain to be allocated, while skills tab shows them all used (due to a homebrew skill being renamed?)

I get an NPE when running the save-as, which probably explains things (sorry, hadn't opened the log last time around!)

Would a view of the .pcg file help, or shall we consider this as user error, and I'll recreate the character

10:23:10.109 INFO main Main:149 Starting PCGen v5.17.20
10:23:10.156 INFO main LanguageBundle:131 Initialising language bundle with locale en_US.
10:23:37.640 INFO Thread-7 SourceFileLoader:519 Loading game 35e and sources [Campaign: Petes Tuesday night game].
10:24:20.31 INFO AWT-EventQueue-1 CharacterManager:173 Loaded character Barin (Barinatharan Solersduin) - D:\MyDocs\Dave\PCGen_Data\Characters\PeteClancyTue\Barin-4.pcg
10:25:08.906 SEVERE AWT-EventQueue-1 PCGen_Frame1:2939 Uncaught error - ignoring
java.lang.NullPointerException
at pcgen.gui2.facade.CompanionSupportFacadeImpl$2.referenceChanged(CompanionSupportFacadeImpl.java:144)
at pcgen.core.facade.DefaultReferenceFacade.fireReferenceChangedEvent(DefaultReferenceFacade.java:86)
at pcgen.core.facade.DefaultReferenceFacade.setReference(DefaultReferenceFacade.java:71)
at pcgen.gui2.facade.CharacterFacadeImpl.setFile(CharacterFacadeImpl.java:2596)
at pcgen.gui2.PCGenFrame.showSaveCharacterChooser(PCGenFrame.java:951)
at pcgen.gui2.PCGenActionMap$SaveAsAction.actionPerformed(PCGenActionMap.java:660)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.AbstractButton.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$400(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at pcgen.gui.PCGen_Frame1$WaitCursorEventQueue.dispatchEvent(PCGen_Frame1.java:2934)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

James Dempsey
October 20, 2012, 3:58 PM

Specific issue with companion not loaded fixed and I've also added an error message if the save fails at that late stage.

Fixed

Assignee

James Dempsey

Reporter

Dave Griffin

Labels

None

Theme

None

Epic/Theme

None

Pending User Input

None

Components

Fix versions

Affects versions

Priority

Major
Configure