Free clothing Chooser not always shown

Description

The free clothes at 1st level chooser option, per the rules, should only offer Outfits that are 10gp less, instead it is offering any outfit regardless of cost.

The tag that fires the chooser in the equip file is the TYPE 'Clothing'. However, there is something else that is checked that isn't obvious (code only checking?), as there are other TYPE 'Clothing' items in various equipment data set lists. It is not the TYPE tag 'Starting' either, as removing that the clothing options still display in the chooser. Neither is it >name of outfit< (Outfit) as there are other instances of that format in other data set equipment files.

In discussing the matter with Andrew Maitland, his suggestion is to have the chooser fire off the TYPE tag 'StartingOutfit'.

Currently this is being worked around by removing the 'Clothing' TYPE from the items that should not be displayed and leaving 'Clothing' and adding 'StartingOutfit' has been added as a TYPE to those that should be displayed.

Environment

Windows, Java 1.7

Activity

Show:
Stefan Radermacher
September 18, 2013, 5:05 AM

Yes, you used "StartingOutfit" as a type in your update, but that is not a type that is known to the code in any way, so it will not have any effect on the chooser.

Rob Reed
September 18, 2013, 5:34 AM

Ah okay. Yes, after talking with Andrew about the problem, 'StartingOutfit' was what he wanted for the TYPE for the code to look for as the code fix...

I just put that in the data files now to a) have it in place and b) to allow the 'Free Clothing at 1st Level' kit in the CR data set to work properly.

Once the code is fixed, the 3 items that I changed their TYPE on from 'Clothing' to 'Outfit', I'll change back to Clothing... they were changed just to avoid the chooser picking them up for now.

James Dempsey
September 18, 2013, 6:07 AM

The main issue I could see in the code was that the clothing was not offered quite often, based on what data was in the global equipment list. I've fixed this now. I've also checked in corrected types for the outfits which works for me in that the royal outfit etc is not offered. Please give it a go.

Rob Reed
September 18, 2013, 6:28 AM

So to clarify, clothing that qualifies for free clothing at first level, in the data files, requires both TYPE's 'Clothing' and 'Starting' and only that particular pairing on an item will let it show in the chooser?

The code now recognizes the 10gp or less requirement as well?

(I'll grab the nightly build tonight and beat the heck out of it, I just wanted to make sure I understood your comments James.)

Stefan Radermacher
September 18, 2013, 7:14 AM

The "Starting" type was added to those outfits costing 10 gp or less, because we did not want to hardcode something like the 10 gp limit into the code. Some other game mode might handle this issue differently, so we decided on a type to differentiate.

Fixed

Assignee

James Dempsey

Reporter

Rob Reed

Theme

None

Epic/Theme

None

Pending User Input

None

Components

Fix versions

Affects versions

Priority

Minor
Configure