Headband of Intellect Skill Choice freezes

It seems to depend on the order or skill selection. With the attached character, the bug appears to be reproducible by adding Craft (Alchemy) to the Headband skill list.

Thanks for the extra info - I can reproduce this intermittently now using the supplied character.

I've traced the issue here and put in a stop to the endless looping, however I have not been able to isolate and resolve the root cause. The issue does seem to be specific to something in the character though, so I expect it is not a widespread problem.

What is occurring is that when the bonus skill ranks from the headband are applied the system for some reason cannot get the class skill bonus to the skill and the linked conditional skill bonuses settled. Each time around the bonus calculation come sup with a very slightly different answer. The system then tries again t get a stable answer.This is where the endless loop comes from.

I have added a cap on the number of retries, along with some reporting code. However this will still mean the calculation for the character are a lot slower than should be expected (by around 20x).

Example looping output

Work around

A work around for now is to spend a real skill point in that skill. I have attached a patched copy of the character with the skill added.

we good to close out this issue? Been over a year since it was last commented and we're almost two years for the actual commit.

This issue good to be closed?