Remaining feat count corrupted on load

Description

Number of availabe feats -9 / -9 at level 20 fighter

Environment

Windows 8

Activity

Show:
Levente Dézsi
June 9, 2014, 7:46 AM

Adding one standard feat save/load it distracts two from the available feats.

James Dempsey
June 9, 2014, 4:28 PM

Thanks for the detective work! We can reproduce this now

James Dempsey
June 11, 2014, 5:12 AM

I've spent some time tracing this in both trunk and 6.2 branch. In the 6.2 branch code, when a character is loaded, the abilities are added directly to the facet (see pcgen.core.PlayerCharacter.addAbility(Category<Ability>, Ability)). In the trunk code however, the abilities are sent through pcgen.core.AbilityUtilities.finaliseAbility(PlayerCharacter, CNAbilitySelection) which charges the pool again. Would you be able to have a look at it please?

Tom Parker
June 15, 2014, 4:56 PM

Proposed Patch - changes how Feat Pools are calculated

Note: FEATPOOL line is now ignored, rather it is the USERPOOL line for FEAT that will control the value (overwrites the FEATPOOL line)

Note also: FEATPOOL is not currently written with the same value as 6.2
(so may need to address this, but since it's ignored...)

Tom Parker
June 16, 2014, 8:37 AM

svn 24155

Fixed

Assignee

Tom Parker

Reporter

Levente Dézsi

Labels

Theme

None

Epic/Theme

None

Pending User Input

None

Fix versions

Affects versions

Priority

Critical
Configure