6.03.x removes user's ability to add Bestiary Feats to Animal Companion

Description

up until 6.02.1, PCGen was not overly strict about Feats for Animal Companions.
6.03.5 takes literally the list on p.53 **without the last sentence of that paragraph: "GMs might wish to expand this list to include feats from other sources".

Flyby Attack and Hover were added in PF Bestiary; there's no good way to encompass this in 6.03.5

(bad (i.e. excessive) ways include creating custom LST files.)
(poor (ugly) ways include leaving an Animal Companion feat unspent and force adding a normal Feat.)

Environment

None

Activity

Show:
Andrew Maitland
September 2, 2014, 12:57 PM

Switched to Chooser to just granting the feat pool 1 per time taken.
At revision: 25026

Saxum Caribetum
September 2, 2014, 4:30 AM

Agreed with Jeff - "GM Granted Animal Companion Feat" throws an exception:

12:27:12.29 SEVERE AWT-EventQueue-0 CharacterAbilities:398 Failed to add ability due to
java.lang.UnsupportedOperationException
at java.util.Collections$UnmodifiableCollection.removeAll(Unknown Source)
at pcgen.cdom.primitive.NegatingPrimitive.getCollection(NegatingPrimitive.java:53)
at pcgen.cdom.primitive.CompoundAndPrimitive.getCollection(CompoundAndPrimitive.java:96)
at pcgen.cdom.choiceset.CollectionToChoiceSet.getSet(CollectionToChoiceSet.java:63)
at pcgen.cdom.base.BasicChooseInformation.getSet(BasicChooseInformation.java:229)
at pcgen.cdom.choiceset.CollectionToAbilitySelection.getAvailableList(CollectionToAbilitySelection.java:193)
at pcgen.cdom.choiceset.CollectionToAbilitySelection.addMultiplySelectableAbility(CollectionToAbilitySelection.java:149)
at pcgen.cdom.choiceset.CollectionToAbilitySelection.processAbility(CollectionToAbilitySelection.java:114)
at pcgen.cdom.choiceset.CollectionToAbilitySelection.getSet(CollectionToAbilitySelection.java:92)
at pcgen.cdom.base.BasicChooseInformation.getSet(BasicChooseInformation.java:229)
at pcgen.core.chooser.CDOMChoiceManager.getChoices(CDOMChoiceManager.java:44)
at pcgen.core.AbilityUtilities.processSelection(AbilityUtilities.java:265)
at pcgen.core.AbilityUtilities.driveChooseAndAdd(AbilityUtilities.java:254)
at pcgen.gui2.facade.CharacterAbilities.addAbility(CharacterAbilities.java:394)
at pcgen.gui2.facade.CharacterFacadeImpl.addAbility(CharacterFacadeImpl.java:677)
at pcgen.gui2.tabs.AbilityChooserTab$AddAction.actionPerformed(AbilityChooserTab.java:698)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$200(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Jeff
August 30, 2014, 7:23 AM

Downloaded 6.03.07-SNAPSHOT-Full (8/28 as 8/29 failed). Base Druid and it Tiger animal companion attached. Error: "Failed to add Ability due to null. See log for further details." when selecting "GM Granted Animal Companion Feat." Pathfinder Society sources.

Jeff
August 30, 2014, 3:19 AM

I will download and test the latest Autobuild when it is posted, hopefully in a few hours. (having ISP issues too).

Saxum Caribetum
August 30, 2014, 12:50 AM
Edited

1) Andrew - I haven't got 6.03.6 to test yet... will do soon! (Festival this weekend...)

2) Comments on Bad, Ugly etc relate to Jeff's comments on how to make PCGen do its stuff without GM Granted Animal Companion Feat.
Jeff also seemed to be posting to suggest that new Feat didn't work - but you'd have to take that up with Geoff.

3) The Animal Companion Feat list in Core has not (will not be) updated - Paizo don't typically retro-fit the early books when later ones come out, and only sometimes include updated lists in the later ones. (So they added new, longer Companion lists in the Bestiaries; but didn't update the Feat lists for them).
Hence, the GM falls back on the Core statement that you can allow other Feats if the GM says - and by the title, Andrew's GM Allowed.. thing should be just right!

Fixed

Assignee

Andrew Maitland

Reporter

Saxum Caribetum