[Paizo] CR - Issues with Weapon Training

Description

Creating a straight Fighter, e.g Human as attached.
Open file, goto Class Features, click "Fighter Class Feature" to expand.
Program goes into an infinite loop with console output repeating:

12:28:23.344 SEVERE AWT-EventQueue-0 AbilityTreeViews:161 Found probable ability prereq cycle [Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows)] with prereqs [Weapon Training (Crossbows),Weapon Training (Crossbows),Weapon Training (Crossbows)]. Skipping.

Environment

Pathfinder Core Rulebooks (set)
6.05.02 and also
overnight build: Built at 2015-06-13 22:55, +1000 for PCGen Version 6.05.03-SNAPSHOT.

(6.05.01 is OK)

Activity

Show:
Andrew Maitland
June 16, 2015, 1:13 PM

There is a code issue here when generating the prereq tree view of abilities. It is getting confused by the not Lvl2, Lv3, Lv4 prereqs for weapon training 1, each of which have prereqs for not having the others already. What I will do there is make the code more robust with duplicated prereqs and also exclude "must not have" prereqs from the tree.
However the display of weapon training looks very odd both in a fixed prereq tree and a name list, with four of each weapon training displayed all with the same name. As a 1st level fighter I can also take weapon training 4. That doesn't seem right, but probably needs to be a separate data tracker as I'll move this one to code once you do.

James Dempsey
June 16, 2015, 2:16 PM

Code issue fixed in

Andrew Maitland
June 16, 2015, 11:56 PM
Edited
  • Switches the prereqs to use the exclusion method we have for Archetypes.

Reviewing set up, Weapon Training is set up correctly for proper Archetype support.

Andrew Maitland
June 17, 2015, 10:05 AM

Seems the issue is Fighter Class Features, which displays anything and everything related to the class itself, is being viewed with the pre-req view - which frankly has never been considered by the Data team. It's an invalid view for this particular pool. No user can actually pick from that list. The Class Feature pool was made to display the automatically granted class features.

However, to make things more manageable, I have completely removed the "Display only" Weapon Training choices from that pool.

This statement doesn't seem accurate "As a 1st level fighter I can also take weapon training 4". Weapon Training 1 through 4 are separate and distinct pools, which are increased at the correct levels. Certainly you can take 4 before 3 and 2 and 1, but that's up to a user and will have no appreciable difference as the code accounts for disparities caused by Archetypes removing the choices of 2 and 3. (It also means you're making the character higher level, and not going in order anyways).

If I make a 1st level fighter, there are NO Weapon Training pools to select from. As we've already established, Class Features for any class are a display/read only, the statement about a 1st level fighter taking weapon training 4 is disproved. That and I would have had a bug report about it well before now. (Since Core rules has been out for several years)

Andrew Maitland
June 17, 2015, 10:16 AM

Final result:
Weapon Training is now displayed correctly in Class Features
Weapon Training Selections for 1 through 4 are no longer seen in Class Features and the criteria now uses TYPE instead of direct keys.

Assignee

Andrew Maitland

Reporter

Saxum Caribetum

Source Books

Pathfinder (Specify)

Epic/Theme

None

Pending User Input

No

Components

Fix versions

Affects versions

Priority

Major
Configure