I created a Human Fighter 1 character as a test. When attempting to apply the Bardic Inspire Courage ~ Not The Bard bonus on the Temporary Bonuses tab, it has no effect on the Character Sheet tab.
Things called Bardic Inspire Courage turn up in a few different places.
Under rsrd_abilities_class.lst we have
In rsrd_templates.lst we have:
In the Temporary Bonuses tab I see that there is a Bardic Inspire Competence from Ability, and a Bardic Inspire Courage ~ Not The Bard from Condition.
I note that Bardic Inspire Courage ~ Is The Bard doesn't appear, which might be a clue as to why this isn't working.
Additionally, even if the .LST code for Inspire Courage did work, inspection of the rsrd_abilities_class.lst implies that it would do the wrong thing.
The intended effect of Inspire Courage is that:
An affected ally receives a +1 morale bonus on saving throws against charm and fear effects and a +1 morale bonus on attack and weapon damage rolls. At 8th level, and every six bard levels thereafter, this bonus increases by 1 (+2 at 8th, +3 at 14th, and +4 at 20th). Inspire courage is a mind-affecting ability.
Per the code snippets above, it looks like:
a bonus would be applied to all saves, which isn't right. Rather, the save bonus is only on will saves vs. charm and fear effects, which should be a SAB: or similar, not a TEMPBONUSC|SAVE|ALL.
The bonuses are of type TYPE=BARDICINSPIRECOURAGE, which isn't quite right. They should be TYPE=Morale bonuses, so that they stack properly with other morale bonuses i.e. the Bless spell.
Probably the best solution, for showing the Inspire Courage bonus on characters that aren't bards, is to have something like:
Note that the Inspire Courage bonus isn't strictly tied to the Bard's level. There are at least three things that can be used to buff the Inspire Courage bonus - the feat Song of the Heart (+1), the item Badge of Valor (+1, 3/day), and the 1st level spell Inspirational Boost (+1). Therefore it's more appropriate for the %CHOICE to ask for the total Inspire Courage bonus instead of the Bard level. The user can select the appropriate bonus accounting for any buffs they have.
Note 2: I am only just learning the .LST format, so the above code probably won't work as written.
Fast? Fast is usually within an hour of the report (or relative within a day). But thanks for the gratitude. Not often I get reports on the 3.5e materials. All my focus is pathfinder these days.
Oh, last task... "Confirm Issue Fixed" if the fix works... cause I haven't gotten to test anything. Just fixing and pushing things out.
Bug not fixed in PCGen 6.05.03.
Applying the "Bardic Inspire Courage" temporary bonus does nothing.
On the Temporary Bonuses tab, in the description box, I can see -
Bardic Inspire Courage (Ability) Target: Unnamed 1 Effect: +0 COMBAT DAMAGE.MELEE,DAMAGE.RANGED, +0 COMBAT TOHIT, +2 VAR OTHERINSPIRECOURAGEBONUS, +0 VAR OTHERINSPIRECOURAGESAVES,OTHERINSPIRECOURAGEATTACK,OTHERINSPIRECOURAGEDAMAGE Source: Wizards of the Coast - Revised (v.3.5) System Reference Document
It seems like the CHOICE is working correctly, but the value of the CHOICE isn't flowing onto the other variables.
I see that the VAR with the CHOICE is last in the list of tags, is PCGen sensitive to the ordering of tags?
Yes, PCGen is sensitive to ordering WHEN it comes to DESC:.CLEAR <> DESC:New Desc stuff here <> DESC:.CLEAR <> DESC:Something else.
Will display "Something else"
However, the issue at had is the ability is never "granted" to the PC. Thus, the DEFINEs are never applied. Ergo, the bonus is "NULL" since a DEFINE does not exist. The solution is to put the DEFINE tags in an ability or object that is granted to the PC. Another useful nugget of knowledge. VAR not granted a value by a CHOOSE does not seem to be acknowledged. Thus I had to change the Inspire Competence set up with a direct bonus.
Confirmed fixed in data files from live Git.