Race is broken if have Racial HD

Description

create a new character, race = goblin, create monster, Goblin Default – bingo, all is well, and the cheeky chappie ends up with 1 level of Warrior.

race = Gnoll, create monster, Gnoll Default - oops! It isn't applying the Racial HD, and so the Skill pool is empty, and the Skills can't be applied, and the Feats pool is empty - see screen capture.

I found this trying to verify the more complex case of DATA-2456, where the Monster kit is new...

Going back to 6.05.03, I am prodded to remember, that even before applying a Kit, when you select the Race, it immediately adds the 2 levels of Humanoid... so the Kit will work.
The problem is 6.05.04 and 6.05.05-overnight do not apply the Racial HD.


Ooh! better still.
Select a Race with Racial HD - nothing happens.
Without removing the first race, add a second Race. The Level-up dialog appears for the HD of the 2nd race!
And the first race is no longer shown. (E.g. Svirfneblin, then Achaierai)

Nah! it's not quite that consistent. Changing race sometimes mounts the level-up dialog for HD, sometimes not.
Not at all for the first race tried.

Environment

pathfinder core books set

Activity

Show:
James Dempsey
December 22, 2015, 11:57 AM

I've found the root cause. The character, when the kit is tested does not qualify for the humanoid class levels.

Humanoid has these requirements:

These were last changed in commit https://github.com/PCGen/pcgen/commit/62385758ea7735bf8304f0ad4d8e9c6f198c6b7f which was first released in v6.5.4. I'm not too sure what change this is associated with from the comment though.

I didn't trace how the variable was assigned, but it is not set when the code checks for qualification, and as written, the character needs both the variable and the racetype to qualify, hence it is rejected. Could you advise on the intention?

The other piece of the puzzle is that I had "Bypass class prereqs" left on for some reason, hence why I had trouble reproducing this!

Andrew Maitland
December 22, 2015, 8:23 PM

I have a PR ready to go to yank it. However, I'm a bit troubled that the Variable isn't passing. Is this an order of operation issue?

The variables are defined and Bonused based upon the racetype of the creature.
Default internal assigns racetype ability, which holds the DEFINE and BONUS:VAR. This should qualify the creature for their base race class.

James Dempsey
December 22, 2015, 9:06 PM

I'd go with the PR. I'm not surprised about the issue as this action is midway through race application calculations and the order is not strictly defined.The data assumes a particular order of operations which is not defined and thus it is unsafe. It would be fine if the class application were not part of the race application.

Andrew Maitland
December 22, 2015, 11:50 PM

blockquote, div.yahoo_quoted { margin-left: 0 !important; border-left:1px #715FFA solid !important; padding-left:1ex !important; background-color:white !important; } Thanks for the code insight.
Would a pre template work if it is directly on the race? Just trying to get a handle on how to address this in the next cycle.

Cheers,

Sent from Yahoo Mail for iPad

On Tuesday, December 22, 2015, 1:07 PM, JIRA (for James Dempsey ) <jira@pcgenorg.atlassian.net> wrote:

 

 

I'd go with the PR. I'm not surprised about the issue as this action is midway through race application calculations and the order is not strictly defined.The data assumes a particular order of operations which is not defined and thus it is unsafe. It would be fine if the class application were not part of the race application.

 

 

 

 

 

 

 

------------------------------------------------------------------------------
_______________________________________________
Pcgen-trackers mailing list
Pcgen-trackers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pcgen-trackers

James Dempsey
December 23, 2015, 2:32 AM

That would be a good conversation to have after the 6.6 release - can/should the order be defined and if so what it should be.

Fixed

Assignee

Andrew Maitland

Reporter

Saxum Caribetum

Labels

None

Source Books

Pathfinder (Specify)

Epic/Theme

None

Pending User Input

Yes

Fix versions

Affects versions

Priority

Major