Rogue Archetypes not removing Uncanny Dodge

Description

None of the Rogue archetypes that replace Uncanny Dodge are doing so. They don't seem to work with the standard or Unchained Rogue.

Environment

None

Activity

Show:
Johannes E.
January 9, 2016, 2:57 PM
Edited

Hello - I have created a pull request on github for this issue. I believe I have learned enough about PCGen .lst files that I should be able to make some contributions to the project now!

Update: I have no clue why the Travis CI build fails - my PCgen is completely happy and accepted the changes without errors....

Andrew Maitland
January 9, 2016, 5:03 PM

Hi

It's "failing" cause you've altered the expected results of a Unit Test - specifically the one for Pathfinder Rogues. Something I would expect if I altered how Rogues worked...

If you click on the red x it takes you to the tests to give an indication of what happened:

https://travis-ci.org/PCGen/pcgen/builds/101267842

Basically, your code added something to the character, the test flags any difference in expected outcome for us to review. In this case, the unit test would have to be updated to accept the new changes. Deleting your repo and redoing the pr won't change that fact. PCGen will run just fine. Same thing will happen if you alter a gold dragon, a paladin, or a cleric.

Re-submit the patch, and let me handle the unit test, since those are more a code thing than a data thing.

Cheers,

Johannes E.
January 9, 2016, 5:13 PM

Hi,
Sorry I wasn't aware of that, I thought I screwed up something in the process. I'll re-commit my changes!

Assignee

Johannes E.

Reporter

Gjorbjond

Labels

None

Source Books

PF - Core Rule Book

Epic/Theme

None

Pending User Input

No

Components

Fix versions

Affects versions

Priority

Minor
Configure