DAMAGEMULT doesn't account for non-Strength based damage

Description

  1. Add Unchained book

  2. Pick half-elf

  3. Pick Ancestral Arms racial trait

  4. Take free Exotic Weapon Proficiency (Elven Curve Blade)

  5. Put 20 in dex

  6. Select rogue class

  7. Select unchained rogue in Rogue class selection

  8. Add 2 more levels of rogue

  9. Select Elven curve blade as Unchained Rogue Finesse Damage Choice

  10. Buy and equip Elven curve blade

  11. Check character sheet: damage is 1D10

Expected: damage is 1D10 + 7 (1.5 x dex modifier as it's a two handed weapon)

Environment

None

Activity

Show:
Andrew Maitland
November 22, 2018, 5:07 PM

CODE TEAM - I’ve isolated this as best I can to something blocking the modifier from this newer tag when the STRENGTH Score is below 10. BONUS:WEAPONPROF=%LIST|STATDAMAGE|DEX-STR works fine for the positive numbers, but as soon as the value drops to 0 any alternatives are failing. If I drop the -STR, and just put a flat 20 value, it stops at countering the STR penalty only, leaving the value at 0 for the Stat Modifier. I believe this to be a CODE bug, as I lose all control of the values and cannot correct it.

Andrew Maitland
November 22, 2018, 5:12 PM

Did you want to address this as a patch to 6.08, or just handle with the new formula system in 6.09.x?

It’s a corner case situation, so I’ll understand if you don’t want to patch it for 6.08, and with the replacement system looming ahead.

Stefan Radermacher
November 22, 2018, 6:43 PM

This is a data issue and can be fixed by changing

cr__stats.lst, line 4 to use BONUS:COMBAT|DAMAGEMULT:2|if(STR>0,1.5,1)

and in

pu_abilities_class, line 395 add BONUS:WEAPONPROF=%LIST|DAMAGEMULT:2|if(DEX>0,1.5,1)-if(STR>0,1.5,1)

Andrew Maitland
November 22, 2018, 7:10 PM
Stefan Radermacher
November 23, 2018, 8:30 AM

Added PR https://github.com/PCGen/pcgen/pull/4459 to apply the fix for off-hand weapons as well.

Assignee

Andrew Maitland

Reporter

Jerome Touffe-Blin

Labels

Source Books

None

Epic/Theme

None

Pending User Input

No

Fix versions

Affects versions

Priority

Minor
Configure