[Pathfinder] Piranha Strike calculation issues
Pirahna Strike calculation is missing the -50% factor for off-hand damage bonus, calculates the bonus incorrectly for BAB's beginning with 8, and for primary natural single which should not get +50% damage bonus the way Power Attack does.
I think this was copied from Power Attack initially and incorrectly converted, since the rules they are based on are slightly different. It also looks like Power Attack might not be implemented correctly for high BABs, but I'm not going to check that here.
This is a partial fix. I don't think it is fully fixable at this time.
It appears that DAMAGE-PRIMARY and DAMAGE-SECONDARY do nothing even through they are combat tokens listed in combat.java.
I’m at a loss for how to fix this.
I’m trying to fix the standard OS now. I’ve set DAMAGE-PRIMARY and DAMAGE-SECONDARY separately for the weapon tables to show correctly with Piranha Strike. The consequences for TWF: when using simple OS’s you have to add two TEMPBONUS’s (one for light/primary and one for off-hand/secondary; for standard OSs you should only add one Piranha Strike TEMPBONUS otherwise you will get non-sense like the Piranha Strike (Off-Hand) table showing the non-offhand values. It looks like there is no good solution that will work for both statblock export and standard export. But I’m still looking.
The problem with the weapons blocks that show 1H-P, 1H-O, 2W-P, etc. are more severe. For one the calculation is not correct for 1H-O, 2H, or 2W-O. Another issue is that it doesn’t make sense to display a table for Longsword [Power Attack (Off-Hand)] and show in that table any values other than 1H-O and 2W-O.
The problems exists for both Power Attack and Piranha Strike.
I can only fix the DATA calculations for proper display in the statblock preview and simple OS, (and probably any other OS that doesn’t try to display a weapon table with 2-handed or off-handed use.
I have a fix for the Preview pathfinder statblock OS that calculates the correct values for BAB 8 for off-hand and light weapons. And it works with PDF export using csheet_simple_*. However it doesn't work with csheet_std_*. The wrong bonuses are being used for 1W-O and 2W-O. This must be a problem with the csheet_std_* OS’s.