Incorrect data for Dawnflower Dervish (Pathfinder - Inner Sea Magic)

Description

There are currently two mistakes in the Dawnflower Dervish bard archetype's abilities:

  • Mising simple weapon proficiencies: They trade out their rapier & whip proficiencies for scimitar proficiency, similar to the Dervish Dancer's weapon proficiency modifications. The Dawnflower Dervish Weapon Proficiencies ability should grant weapon proficiencies AUTO:WEAPONPROF|Scimitar|Longsword|Sap|Shortbow|Sword (Short)|TYPE=Auto ABILITY:Internal|AUTOMATIC|TYPE=WeaponProfSimple. [It should also be named "Weapon and Armor Proficiency" to match the official feature name, but this isn't a strict requirement.

  • Meditative Whirl is obtained at level 8, not 18. Prerequisite should be PRECLASS:1,Bard=8.

Apart from this, archetype features don't show up in the Bard Class Feature list on the Class Features tab. I believe this was semi-intentional due to it only being a quick implementation, but it's somewhat annoying. Currently working on fixes (and updating the archetype to show its class features in the Bard Class Feature list), I'll attach them in a simple text file when complete.

Environment

None

Activity

Show:
Andrew Maitland
November 24, 2019, 10:06 PM

Hi Any chance I can have you submit the fix via Github? It is a lot easier that method for me, than having to assimilate an outdated file that I’ll have to reconcile.

Thanks!

Justin Wadden
November 25, 2019, 12:12 AM
Edited

Possibly, @Andrew Maitland. Never uploaded anything to Github or made any forks before, I’ll take a look at how to do that once I’ve got it ready.

Justin Wadden
November 25, 2019, 2:04 AM

Okay. Forked and edited the file, and I’d like it to be tested by someone else to make sure it works properly for them, too. It also needs to be run through PrettyLst, which I don’t have a copy of. I believe the next step is to make a pull request, right?

Andrew Maitland
November 25, 2019, 3:46 AM

Just PR. I handle the PrettyLST stuff.

Justin Wadden
November 25, 2019, 7:09 PM
Edited

Okay, done, it’s pull request #6112; I also made a pair of small conformity changes, as noted in the PR. Thanks for the patience & help. ;P

Fixed

Assignee

Andrew Maitland

Reporter

Justin Wadden

Labels

Source Books

Pathfinder (Specify)

Epic/Theme

None

Pending User Input

No

Components

Fix versions

Affects versions

Priority

Minor
Configure