Portrait not displaying in Character Sheet tab

Description

The standard.htm and the compact.htm (in the preview directory) are coded to show the character portrait if there is one.

The portraits are not showing up in the Character Sheet tab when you examine your character there.

As these sheets are coded the same as the actual output sheets, and the portraits show up there I believe it may be a code issue.

Environment

None

Activity

Show:
Andrew Maitland
October 11, 2010, 9:18 PM

To whomever does investigate this

<img src="file://localhost/|PORTRAIT|" height="100%" Width="100%" alt="Click for Bio" border="0" /></a><br /></font></td>

Was the alternate code I used that DID work... note the 'localhost' reference.

Chuck Pint
October 12, 2010, 3:38 PM

Fixed in the trunk, 5.17.3. Needs to be ported to 5.16.4.

Andrew Maitland
October 12, 2010, 4:01 PM

I'll back port the changes when I get home. However, did you test this thoroughly? The code works for me, but the pictures are distorted and stretched. Which is why I didn't commit the code as it only worked partially for me. It's not the same as the htm OS that's for certain.

Chuck Pint
October 12, 2010, 4:20 PM

That is not something I think we can control. I could add a "width=??" to the html, but it really looks like the "browser" for PCGen is doing something it should not. Just setting the "height" for the portrait should do the right thing, the default width is supposed to stay proportional. If I add a width, then it will distort for some things, and look fine for others. I think the display should be a separate code issue.

Chuck Pint
November 5, 2010, 12:39 PM

Still not perfect, but much better. The browser inside PCGen is not doing standard HTML resizing. I've set height=100%, and width=100 (note the % on height and lack of % on width). That seems to work better, but it still distorts the portrait. Fixed at revision 13722 for 5.16.4, revision 13723 for 5.17.4.

Assignee

Chuck Pint

Reporter

Chris Chandler

Labels

None

Epic/Theme

None

Pending User Input

None

Components

Fix versions

Affects versions

Priority

Minor
Configure