Skill not listed correctly on various preview and output sheets

Description

On various preview and output sheets the skill list has some problems:

Examples:
Standard.htm preview: last skill in list gets eaten
Standard.htm.flt: does not list situational skills

Environment

None

Activity

Show:
Stefan Radermacher
January 6, 2015, 11:00 AM

Submitted pull request #14 to fix this issue.

Matthew Morse
January 8, 2015, 11:45 AM
Edited

I have a partial fix for this, but not sure where to submit:

Standard.htm can be fixed by adjusting line 1270 to read |FOR,%skill,0,${count("SKILLSIT", "VIEW=VISIBLE_EXPORT")},1,0| as opposed to |FOR,%skill,0,${count("SKILLSIT", "VIEW=VISIBLE_EXPORT")-1},1,0|

(It should be noted that this is a workaround since it appears that the problem lies primarily in the skills output being sent to the template. If you implement this fix BACK UP the original first.)

This fix does not affect the second problem listed, nor does it affect the bug report I am about to submit about the same issue for the standard version of the PDF output.

Stefan Radermacher
January 8, 2015, 11:51 AM

Thank you Matthew, that is indeed part of my fix, there were multiple problems resulting from both the switchover to Freemarker and the change from using SKILL to SKILLSIT.

The fix was merged into the repository with pull request #14.

Stefan Radermacher
January 15, 2015, 5:04 PM

The missing skils were due to bug CODE-2801, not due to errors on the OS. Some of the changes from this issue need to be reversed.

Stefan Radermacher
January 16, 2015, 8:11 AM

Submitted pull request #81.

Assignee

Stefan Radermacher

Reporter

Stefan Radermacher

Labels

None

Epic/Theme

None

Pending User Input

None

Fix versions

Affects versions

Priority

Minor
Configure