[BUG] ADD syntax conversion

Description

  • ID: 1729920
    Last Update: Settings changed ( karianna )
    Details:

There is a bug in the ADD syntax conversion, it effects feats which use paraentheses. The first perentheses is being replaces eroniouslly with |1| so you end up with things like:

Armor Proficiency |1|Heavy) and Exotic Weapon Proficiency |1|Katana)

which can't be parsed by PCGen.
Submitted:

Eddy Anthony ( eddyanthony ) - 2007-06-02 10:26:05 EDT
=====
Date: 2007-06-03 06:58:00 EDT
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide

5.14 land it goes then (under our less than ideal designation)

Date: 2007-06-03 06:48:59 EDT
Sender: tir-gwaithSourceForge.net Subscriber and DonorProject Admin & DonorAccepting Donations
Hide

No. It was good enough to release prettylst, but Gawaine thinks he might
be able to fix it with a check for | before the first ( when parse
checking, and might prevent this issue. I don't know how to code that
complexity, so it will have to wait till he has time again.

Date: 2007-06-03 05:45:37 EDT
Sender: kariannaSourceForge.net DonorProject Admin & DonorAccepting Donations
Hide

If this is documented, then should delete

Date: 2007-06-02 17:56:57 EDT
Sender: eddyanthonySourceForge.net SubscriberProject Admin
Hide

Ah, that explains things. I'll need to be more careful with that
conversion. Thanks Tir.

Date: 2007-06-02 17:42:44 EDT
Sender: tir-gwaithSourceForge.net Subscriber and DonorProject Admin & DonorAccepting Donations
Hide

This was noted in my testing. Only happened when running the script on a
file that already had the ADD converted. It was seeing the ( ) and doing
the conversion again.

NOT for 5.12 - also, I think prettylst Groups need to be redefined (since
they don't follow the same exact release stuff as PCGen). The release
notes mentioned the problem with running the conversion more than once.

Date: 2007-06-02 13:37:16 EDT
Sender: eddyanthonySourceForge.net SubscriberProject Admin
Hide

Also note that when such a feat comes at the end of the list the closing
parentheses is removed as well.

Environment

None

Assignee

Unassigned

Reporter

User Submissions

Labels

None

Epic/Theme

None

Pending User Input

None

Priority

Minor
Configure